On Wed, 1 Mar 2023 23:43:55 GMT, Paul Sandoz <psan...@openjdk.org> wrote:
>> Adam Sotona has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - renamed all remaining ConcreteXyzEntry to XyzEntryImpl
>> - abstract implementations of RefEntry, RefsEntry and NamedEntry renamed to
>> AbstractRefEntry, AbstractRefsEntry and AbstractNamedEntry
>> - renamed ConcreteBootstrapMethodEntry to BootstrapMethodEntryImpl
>> - ConcreteEntry renamed to AbstractPoolEntry
>
> src/java.base/share/classes/jdk/internal/classfile/attribute/CodeAttribute.java
> line 56:
>
>> 54: * @param label a marker for a position within this {@code
>> CodeAttribute}
>> 55: * @return position of the {@code Label} in the {@code codeArray}
>> 56: */
>
> Suggestion:
>
> /**
> * {@return the position of the {@code Label} in the {@code codeArray}}
> * @param label a marker for a position within this {@code CodeAttribute}
> */
>
> Throws IAE if the label is not positioned in the code array?
All the dependent code expects -1 when the Label is not positioned in the code
array.
Throwing IAE would require significant refactoring and may have performance
effects.
I'll add a javadoc comment meanwhile.
-------------
PR: https://git.openjdk.org/jdk/pull/10982
