On Wed, 1 Mar 2023 16:59:51 GMT, Roger Riggs <rri...@openjdk.org> wrote:

>> Consolidate logging and handle exceptions by printing to standard error and 
>> ignoring the exception.
>> Exceptions while logging will not interfere with Runtime.exit.
>
> Roger Riggs has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Add exit status to output when the logging fails with an exception.

I think this looks okay. The main goal is to make it easy to identify the code 
that is calling System.exit and this seems as robust as it can be. The issue of 
racing exits can be looked at again, if it turns out to be interesting.

-------------

Marked as reviewed by alanb (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12770

Reply via email to