On Fri, 3 Mar 2023 21:10:57 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> This change is to fix a regression caused by the fix to >> [JDK-8234347](https://bugs.openjdk.org/browse/JDK-8234347). The previous fix >> was simply disabling offset-based parsing if the parser was text-based. >> Instead, check if it is an offset or not by explicitly comparing the >> character with '+'/'-' and continue offset parsing if it is. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > now() -> of() to avoid DST test/jdk/java/time/test/java/time/format/TestUTCParse.java line 27: > 25: * @modules jdk.localedata > 26: * @bug 8303440 > 27: * @summary Test parsing "UTC-XX:XX" text works correctly Hello Naoto, I haven't tried it, but without a `@run testng` instruction, does jtreg have the ability to auto infer this as a testng testcase? test/jdk/java/time/test/java/time/format/TestUTCParse.java line 48: > 46: // Assuming CLDR's SHORT name for "America/Los_Angeles" > 47: // produces "UTC\u212208:00" > 48: System.setProperty("java.locale.providers", "CLDR"); Since this updates a system property (that's recognized by code even outside of this test), perhaps we should use `@run testng/othervm` to prevent interfering with other tests? ------------- PR: https://git.openjdk.org/jdk/pull/12868
