On Thu, 2 Mar 2023 23:49:24 GMT, Paul Sandoz <psan...@openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   StackMapFrameInfo extracted to top level from StackMapTableAttribute
>
> src/java.base/share/classes/jdk/internal/classfile/CodeTransform.java line 91:
> 
>> 89:     @Override
>> 90:     default ResolvedTransform<CodeElement> resolve(CodeBuilder builder) {
>> 91:         return new TransformImpl.CodeTransformImpl(e -> accept(builder, 
>> e),
> 
> Make `CodeTransformImpl` generic in the class file element, rename to say 
> `ResolvedTransformImpl<E>` and reuse for the other `XxxTransform`?

Good idea, I'll fix it, thanks.

-------------

PR: https://git.openjdk.org/jdk/pull/10982

Reply via email to