On Thu, 15 Dec 2022 14:56:03 GMT, Adam Sotona <asot...@openjdk.org> wrote:
> 8294966: jdk.jartool sun.tools.jar.FingerPrint uses ASM to parse class jar > entries > This patch converts it to use Classfile API. > > Please review. > Thanks, > Adam make/modules/jdk.jartool/Java.gmk line 28: > 26: DISABLED_WARNINGS_java += missing-explicit-ctor > 27: JAVAC_FLAGS += -XDstringConcat=inline > 28: JAVAC_FLAGS += --enable-preview This change is no longer needed. It's not a preview API. src/java.base/share/classes/module-info.java line 155: > 153: jdk.incubator.concurrent, // participates in preview features > 154: jdk.incubator.vector, // participates in preview features > 155: jdk.jartool, // participates in preview features This is no longer needed. src/jdk.jartool/share/classes/module-info.java line 52: > 50: * @since 9 > 51: */ > 52: @ParticipatesInPreview Same here. No needed. src/jdk.jartool/share/classes/sun/tools/jar/FingerPrint.java line 252: > 250: private final int access; > 251: private final boolean publicClass; > 252: private boolean maybeNestedClass; should be final since this is no longer updated. ------------- PR: https://git.openjdk.org/jdk/pull/11694
