On Thu, 9 Mar 2023 22:38:32 GMT, Mandy Chung <mch...@openjdk.org> wrote:
>> Adam Sotona has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 207 commits: >> >> - Merge branch 'master' into JDK-8294972-jlink-plugins >> - fixed SystemModulesPlugin formatting >> - 8303624: The java.lang.Thread.FieldHolder can be null for JNI attaching >> threads >> >> Reviewed-by: alanb, dcubed >> - 8302360: Atomic*.compareAndExchange Javadoc unclear >> >> Reviewed-by: martin, dholmes >> - 8302779: HelidonAppTest.java fails with "assert(_cb == >> CodeCache::find_blob(pc())) failed: Must be the same" or SIGSEGV >> >> Reviewed-by: coleenp, sspitsyn >> - 8303691: Fedora based devkit build should load more packages from archive >> location >> >> Reviewed-by: mbaesken, erikj >> - 8303924: ProblemList serviceability/sa/UniqueVtableTest.java on Linux >> >> Reviewed-by: dcubed >> - 8303609: ProblemList serviceability/sa/TestSysProps.java with ZGC >> >> Reviewed-by: dcubed >> - 8289765: JDI EventSet/resume/resume008 failed with "ERROR: suspendCounts >> don't match for : VirtualThread-unparker" >> >> Reviewed-by: sspitsyn, kevinw >> - 8301074: Replace NULL with nullptr in share/opto/ >> >> Reviewed-by: kvn, jwilhelm >> - ... and 197 more: https://git.openjdk.org/jdk/compare/e26cc526...ec1126f7 > > src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java > line 619: > >> 617: "<init>", >> 618: >> MethodTypeDesc.of(CD_void), >> 619: false); > > nit: extra space > > sorry this might be from the patch I sent you. fixed, thanks. > src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java > line 1644: > >> 1642: CD_SYSTEM_MODULES_MAP, >> 1643: clb -> { >> 1644: clb.withFlags(ACC_FINAL+ACC_SUPER); > > Nit: consistent with line 578 with a space before and after `+` fixed, thanks. ------------- PR: https://git.openjdk.org/jdk/pull/12944
