On Thu, 9 Mar 2023 18:36:05 GMT, Mandy Chung <mch...@openjdk.org> wrote:
>> Adam Sotona has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 198 commits: >> >> - ModuleInfoWriter fixes >> - ModuleInfoExtender comment fix >> - Merge branch 'master' into JDK-8294962-internal-module >> - Update >> src/java.base/share/classes/jdk/internal/module/ModuleInfoExtender.java >> >> Co-authored-by: Mandy Chung <mandy.ch...@oracle.com> >> - Merge branch 'master' into JDK-8294962-internal-module >> - fixed jdk.internal.classfile.java.lang.constant package name >> - Merge branch 'JDK-8294982' into JDK-8294962 >> - removed obsolete javadoc from implementation classes >> - minor fix in CodeBuilder and added test cases to LDCTest >> - EntryMap::nextPowerOfTwo delegates to Long:numberOfLeadingZeros >> - ... and 188 more: https://git.openjdk.org/jdk/compare/e26cc526...9e366fbd > > src/java.base/share/classes/jdk/internal/module/ModuleInfoExtender.java line > 170: > >> 168: } >> 169: >> 170: // add ModuleTarget, ModuleResolution and ModuleHashes >> attributes > > This adds or replaces if the attribute exists. Perhaps just drop "add" from > the comment? fixed, thanks. > src/java.base/share/classes/jdk/internal/module/ModuleInfoWriter.java line > 138: > >> 136: for (ModuleDescriptor.Provides p : md.provides()) { >> 137: mb.provides(ClassDesc.of(p.service()), >> 138: p.providers() > > Formatting nit: align `p.providers()` with the first parameter to > `mb.provides` - a little confusing with current indentation. fixed, thanks. ------------- PR: https://git.openjdk.org/jdk/pull/11368
