On Fri, 10 Mar 2023 21:21:56 GMT, Roger Riggs <rri...@openjdk.org> wrote:

>> Improvements to support OS specific customization for JDK internal use:
>>  - To select values and code; allowing elimination of unused code and values
>>  - Optionally evaluated by build processes, compilation, or archiving (i.e. 
>> CDS)
>>  - Simple API to replace adhoc comparisons with `os.name`
>>  - Clear and consistent use across build, runtime, and JDK modules
>>  
>> The PR includes updates within java.base to use the new API.
>
> Roger Riggs has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Move OperatingSystem from jdk.internal.misc to jdk.internal.util
>   Rename Mac -> MacOS; isMac() -> isMacOS()

src/java.base/unix/classes/sun/net/PortConfig.java line 64:

> 62:                 break;
> 63:             default:
> 64:             throw new InternalError(

I think it needs to be indented here.

-------------

PR: https://git.openjdk.org/jdk/pull/12931

Reply via email to