On Tue, 14 Mar 2023 22:52:44 GMT, Martin Doerr <mdo...@openjdk.org> wrote:

>> Martin Doerr has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Fix storing 32 bit integers into Java frames. Enable TestArrayStructs.
>
> Btw. the new cases in which we use int and short accesses when byteWidth is 
> not a power of 2 are never unaligned AFAICS. I guess _UNALIGNED is 
> unnecessary in the JAVA_INT_UNALIGNED and JAVA_SHORT_UNALIGNED. They are 
> always aligned wrt. to their size.

> @TheRealMDoerr I've approved the PR. I suggest for a second reviewer to try 
> and get someone who knows the PPC port.

Thanks for the review! I guess I should also wait for your 2 PRs to be 
integrated, so I can merge and adapt.

-------------

PR: https://git.openjdk.org/jdk/pull/12708

Reply via email to