On Thu, 16 Mar 2023 14:50:14 GMT, Alan Bateman <[email protected]> wrote:
>> test/jdk/java/util/ServiceLoader/BadProvidersTest.java line 216:
>>
>>> 214: clb.withSuperclass(CD_Object);
>>> 215: clb.withFlags(AccessFlag.PUBLIC, AccessFlag.SUPER);
>>> 216: var provider$1Desc = ClassDesc.of("p",
>>> "ProviderFactory$1");
>>
>> This is class descriptor for ProviderFactory$1, not "Provider" so maybe
>> rename this to providerFactory1 or something a bit clearer.
>
>> This is class descriptor for ProviderFactory$1, not "Provider" so maybe
>> rename this to providerFactory1 or something a bit clearer.
>
> The updated version looks good. I assume you'll do a pass over the updated
> tests to bump their copyright date as this is the first change in 2023 for
> many of these tests.
Yes, the copyright years are updated. Tested Serializable, instrument, and
LambdaStackTrace as of "[Fix LambdaStackTrace after
running](https://github.com/openjdk/jdk/pull/13009/commits/a728c9de1ff684bd30726eb8ea6e7a674cb5a140)"
-------------
PR: https://git.openjdk.org/jdk/pull/13009
