On Tue, 21 Mar 2023 18:38:06 GMT, Mandy Chung <mch...@openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Alan's suggestions - don't parse arch out of osname-arch for determining 
>> endianness and reduce the number of supported/known target platforms for 
>> cross linking
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Platform.java line 192:
> 
>> 190:             case "s390x"           -> Architecture.s390x;
>> 191:             case "sparc"           -> Architecture.SPARC;
>> 192:             case "sparcv9"         -> Architecture.SPARCv9;
> 
> This list should be trimmed to the ones supported in the mainline as in 
> `target.properties`.

Also `is64Bit` will need update for other 64-bit platforms.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/11943#discussion_r1143865820

Reply via email to