On Thu, 23 Mar 2023 11:43:33 GMT, Viktor Klang <[email protected]> wrote:
>> Improves the stability of the memory leak test for CompletableFuture timeout
>> cancellation by both reducing the count by 50% (which should still be above
>> threshold to trigger given the ample margin set initially) as well as
>> extending the default timeout of the test run.
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Changing the test to monitor the internals instead of trying to provoke an
> OOME
Changes requested by aturbanov (Committer).
test/jdk/java/util/concurrent/CompletableFuture/CompletableFutureOrTimeoutExceptionallyTest.java
line 62:
> 60: assertTrue(delayerQueue.peek() != null);
> 61: future.completeExceptionally(new RuntimeException("This is
> fine"));
> 62: while(delayerQueue.peek() != null) {
nit
Suggestion:
while (delayerQueue.peek() != null) {
test/jdk/java/util/concurrent/CompletableFuture/CompletableFutureOrTimeoutExceptionallyTest.java
line 76:
> 74: assertTrue(delayerQueue.peek() != null);
> 75: future.completeExceptionally(new RuntimeException("This is
> fine"));
> 76: while(delayerQueue.peek() != null) {
Suggestion:
while (delayerQueue.peek() != null) {
-------------
PR Review: https://git.openjdk.org/jdk/pull/13116#pullrequestreview-1354517634
PR Review Comment: https://git.openjdk.org/jdk/pull/13116#discussion_r1146119198
PR Review Comment: https://git.openjdk.org/jdk/pull/13116#discussion_r1146119371
