On Wed, 15 Mar 2023 19:57:43 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Expand testing to all end of year days that roll into week 1 > > test/jdk/java/util/Calendar/RollToMinWeek.java line 79: > >> 77: return Stream.of( >> 78: // Test a variety of rolls that previously produced >> incorrect results >> 79: Arguments.of(buildCalendar(27, 11, 2020, Locale.ENGLISH), > > The first day of week depends on the region, not the language. In fact, I > would prefer explicitly specifying it via a locale like `en-US-u-fw-mon`, and > testing all the weekdays. Updated the testing ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13031#discussion_r1147939908
