On Sat, 25 Mar 2023 11:07:24 GMT, Eirik Bjorsnos <d...@openjdk.org> wrote:
>> Please add them back before pushing with `@throws IOException if an error >> occurs` >> >> Yes I understand they do not add much value but it will reduce noise from >> IDEs and if/when we add more checks for missing javadoc tags, it will save >> us from having to revisit this > > Thanks, I've added `@throws IOException if an error occurs` to all methods > throwing `IOException`. > > For the record, let me state my personal (rather strong) opinion: > > I think this a pretty crazy level of boilerplate noise for a test and that it > affects readability negatively. My IDE (IntelliJ) does not complain about > this at all. Any IDE which complains should be fixed or configured to not > complain. Changing Javadoc to complain about this in a scope like this would > be a poor decision. > > I think the PR is ready to be sponsored after this. I hear you but the option is not to use javadoc comments and use block comments :-) I think we can agree to disagree on impacting readability ;-) this comes down to personal preferences Again thank you for making the change. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/12231#discussion_r1148353477
