On Mon, 27 Mar 2023 14:44:10 GMT, Maurizio Cimadamore <[email protected]>
wrote:
> The code changes look good, but the javadoc should be updated to reflect the
> new constraints.
We currently have this:
@throws IllegalArgumentException if the provided function descriptor is not
supported by this linker.
Which technically seems enough to cover this as well, as byte order is part of
the layouts that are part of the function descriptor. I'm not sure if we want
to get very detailed here. Different linker implementations might make
different decisions, at least theoretically, but this is also the case for the
fallback linker which e.g. rejects unions and accepts layouts with any byte
order.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/13161#issuecomment-1485296463
