On Tue, 28 Mar 2023 11:00:00 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org> wrote:
>> Per Minborg has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 22 commits: >> >> - Merge with master >> - Make fallbacklinker.c consistent with downcallLinker.cpp >> - Add bug number >> - Use @return >> - Update Linker.downcallHandle() javadoc >> - Fix typos in Arena >> - Make checking method handle zero case >> - Add snippet to Linker.Option.captureStateLayout() >> - Apply RISCV port patch >> - Improve javadocs for Linker::captureStateLayout >> - ... and 12 more: https://git.openjdk.org/jdk/compare/cddaf686...bc29c6fc > > src/java.base/share/classes/java/lang/foreign/MemorySegment.java line 2310: > >> 2308: /** >> 2309: * {@return {@code true}, if the provided object is also a >> scope, which models the same lifetime as that >> 2310: * modelled by this scope}. In that case, it is always the >> case that > > This brace (after `scope`) seems spurious? It's to close the text span for the `{@return` ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13079#discussion_r1150540008
