On Fri, 31 Mar 2023 19:59:10 GMT, Eirik Bjorsnos <d...@openjdk.org> wrote:
>> CorruptedZipFiles could benefit from some spring cleaning and a conversion >> to junit: >> >> - The actual tests are moved into their own `@Test` methods, given more >> meaningful names and a Javadoc comment explaining the constraint being >> verified >> - The setup code is moved to a `@Before` method, slightly modernized and >> rewritten to take advantage of `assertEquals` >> - `checkZipExceptionImpl` is updated to take advantage of `assertThrows` >> - A bunch of constants copied over from `ZipFile` can be deleted since >> JDK-6225935 has long been fixed > > Eirik Bjorsnos has updated the pull request incrementally with four > additional commits since the last revision: > > - Remove the "Validate that " comment prefix > - Spell immediately correctly > - a A -> a > - this -> the Last Mach5 runs continue to be clean so you are good to integrate and then I can sponsor Monday Thank you for your efforts on this clean up Eirik. ------------- Marked as reviewed by lancea (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/12563#pullrequestreview-1368119311
