On Tue, 1 Nov 2022 00:02:46 GMT, David Schlosnagle <[email protected]> wrote:
>> Anyway, i think you are right, this can be public
>
> If this is a public int field, it will be inlined to class file byte code at
> compile time, which may not be what you want if this value needs to change in
> the future. If this needs to be exposed, should it be as a public method?
It can also be initialised in a static initialiser, which will make it no
longer inlined at use‑sites:
Suggestion:
public static final int MAX_INDY_CONCAT_ARG_SLOTS;
static { MAX_INDY_CONCAT_ARG_SLOTS = 200; }
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/10889#discussion_r1160586124
