On Tue, 11 Apr 2023 17:59:32 GMT, Vladimir Ivanov <vliva...@openjdk.org> wrote:
>> Per Minborg has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - 8305369: Issues in zero-length memory segment javadoc section >> - 8305087: MemoryLayout API checks should be more eager > > src/hotspot/share/prims/jvm.cpp line 3473: > >> 3471: >> 3472: JVM_LEAF(jboolean, JVM_IsForeignLinkerSupported(void)) >> 3473: return ForeignGlobals::has_port() ? JNI_TRUE : JNI_FALSE; > > On naming: I find `has_port()` confusing. Why don't you simply call VM > counterpart `is_foreign_linker_supported`? Alternative ideas: > `is_supported()`, `has_native_support()`. Thanks for the review. I've created a patch for changing the name to `is_foreign_linker_supported` here: https://github.com/minborg/jdk/pull/3 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13079#discussion_r1164463475
