On Wed, 19 Apr 2023 03:37:05 GMT, Stuart Marks <[email protected]> wrote:
>> PR for Sequenced Collections implementation.
>
> Stuart Marks has updated the pull request incrementally with three additional
> commits since the last revision:
>
> - Remove unnecessary 'final' from a couple places.
> - Clarify ordering of Collection.addAll and Map.putAll; add links to
> encounter order.
> - Make constructors private for several reverse-ordered views.
src/java.base/share/classes/java/util/concurrent/CopyOnWriteArrayList.java line
409:
> 407: * {@inheritDoc}
> 408: */
> 409: public E getFirst() {
Javadoc will automatically copy the specification from the overridden method,
so the javadoc block is not necessary and can be replaced by an `@Override` to
indicate inheritance.
src/java.base/share/classes/java/util/concurrent/CopyOnWriteArrayList.java line
1716:
> 1714: * in the reversed view. Sublists and iterators of the reversed
> view have
> 1715: * the same restrictions as those of this list.
> 1716: */
Suggestion:
*
* @since 21
*/
Per
[8029241](https://bugs.openjdk.org/browse/JDK-8029241?focusedCommentId=14492604&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14492604),
`@since` tags are not inherited at all and must be manually specified each
time.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/7387#discussion_r1170797315
PR Review Comment: https://git.openjdk.org/jdk/pull/7387#discussion_r1170797866
