On Wed, 19 Apr 2023 05:50:00 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix gtests
>
> test/jdk/java/lang/Thread/SleepSanity.java line 75:
>
>> 73: }
>> 74:
>> 75: private static void testTimes(TestCase t, long min, long max) throws
>> Exception {
>
> Not obvious without reading all the code that min and max are in ms. `msMin`
> and `msMax` might be clearer.
Done.
> test/jdk/java/lang/Thread/SleepSanity.java line 84:
>
>> 82: }
>> 83:
>> 84: private static void testTimeout(TestCase t, long timeout) throws
>> Exception {
>
> Suggestion: s/timeout/millis/ again so unit is clear.
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13225#discussion_r1171043726
PR Review Comment: https://git.openjdk.org/jdk/pull/13225#discussion_r1171043842
