On Thu, 20 Apr 2023 00:40:44 GMT, Jorn Vernee <jver...@openjdk.org> wrote:

>> Also, isn't it the case that, for structs, we want the size of the layout to 
>> be a multiple of its alignment constraint?
>
> The third item in the list is for group size needing to be a multiple of the 
> alignment constraint, the forth item refers to that, so I'll keep the ordered 
> list.
> 
> WRT byte order: I think it's fine to just say "native byte order". Keep it 
> simple. Or do you think there might be confusion about the meaning of 
> "native"? (It looks like not even ByteOrder::nativeOrder explains that term: 
> https://docs.oracle.com/en/java/javase/20/docs/api/java.base/java/nio/ByteOrder.html#nativeOrder())
> 
> "padding layout elements" is not quite right I think, since they also have to 
> be the right size. I think saying just "padding" is more accurate (and 
> simpler).
> 
> I'll switch to using plain links instead.

Uploaded another version

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13164#discussion_r1171979964

Reply via email to