On Thu, 20 Apr 2023 17:06:26 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Hash map should be initialized with numMappings
>
> make/jdk/src/classes/build/tools/generatelsrequivmaps/EquivMapsGenerator.java
> line 143:
>
>> 141: // eg: ar-ajp has pref ajp which has pref apc
>> 142: boolean foundInOther = false;
>> 143: Pattern pattern =
>> Pattern.compile("\\b"+preferred+"\\b");
>
> I think we should explicitly find a pattern with `,` instead of the word
> boundary. Otherwise, it could match `-` in a tag.
Good point, changed it to match starting with `,` and ending with `,` or end of
string boundary
> make/jdk/src/classes/build/tools/generatelsrequivmaps/EquivMapsGenerator.java
> line 289:
>
>> 287: + sortedLanguageMap2.size() + ");\n"
>> 288: + " regionVariantEquivMap = HashMap.newHashMap("
>> 289: + sortedRegionVariantMap.size() + ");\n\n"
>
> It'd be nice if these messy concatenated strings be converted to a text
> block, but that would be for another day.
Will file a separate JBS issue for this
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13501#discussion_r1173046730
PR Review Comment: https://git.openjdk.org/jdk/pull/13501#discussion_r1173047129
