On Sun, 23 Apr 2023 22:34:43 GMT, Joe Darcy <da...@openjdk.org> wrote:
> Minor refactoring of FdLibm.java; will consider future refactorings with more > substantive code changes in the future. src/java.base/share/classes/java/lang/FdLibm.java line 76: > 74: private static final int SIGN_BIT = 0x8000_0000; > 75: private static final int EXP_BITS = 0x7ff0_0000; > 76: private static final int EXP_SIGNIF_BITS = 0x7fff_ffff; These could be expressed in terms of the constants in `Double`. But perhaps it's not worth doing so, after all, as the reader is assumed to be quite knowledgeable. Otherwise LGTM. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13604#discussion_r1175183371
