On Mon, 24 Apr 2023 14:35:30 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added links to JVMS and utility methods moved to ConstantUtils > > src/java.base/share/classes/java/lang/constant/package-info.java line 92: > >> 90: * reading and writing APIs. >> 91: * >> 92: * <p>Another members of this package are {@link >> java.lang.constant.ModuleDesc} > > "Another" -> "Other" Fixed, thanks. > test/jdk/java/lang/constant/ModuleDescTest.java line 37: > >> 35: >> 36: class ModuleDescTest { >> 37: > > Add tests for empty and null arguments. added, thanks. > test/jdk/java/lang/constant/PackageDescTest.java line 39: > >> 37: >> 38: class PackageDescTest { >> 39: @ParameterizedTest > > Add tests for empty and null arguments. added, thanks. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13615#discussion_r1175522533 PR Review Comment: https://git.openjdk.org/jdk/pull/13615#discussion_r1175521484 PR Review Comment: https://git.openjdk.org/jdk/pull/13615#discussion_r1175521842