On Tue, 25 Apr 2023 16:26:01 GMT, Mandy Chung <mch...@openjdk.org> wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added custom toString() methods
>
> src/java.base/share/classes/java/lang/constant/PackageDesc.java line 44:
>
>> 42: * given the name of the package, such as {@code "java.lang"}.
>> 43: * <p>
>> 44: * {@jls 13.1}
>
> Do you mean to reference JLS 6.7?
>
> Suggest to move this reference after `throws` in the see also section.
Fixed, thanks.
> src/java.base/share/classes/java/lang/constant/PackageDesc.java line 62:
>
>> 60: * such as {@code "java/lang"}.
>> 61: * <p>
>> 62: * {@jvms 4.2.1} In this internal form, the ASCII periods (.) that
>> normally
>
> Suggest not to copy JVMS 4.2.1 here but instead just add it to see also
> section.
Fixed, thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13615#discussion_r1176954431
PR Review Comment: https://git.openjdk.org/jdk/pull/13615#discussion_r1176951889
