On Tue, 25 Apr 2023 23:58:59 GMT, Justin Lu <j...@openjdk.org> wrote:
>> Please review changes to the IntlTest (test framework) class. >> >> These changes include >> - Logging the actual exception + stack trace. Previously, the test framework >> would throw `InvocationTargetException` but hide the actual underlying >> exception of the failing test unless the test class was ran with -nothrow. >> - Sorting the tests, ensuring for any given run, the tests are ran in the >> same order. (In [JDK-8305853](https://bugs.openjdk.org/browse/JDK-8305853) >> it was discovered that on Windows, the test framework would execute tests in >> a random order each time). >> - Improving output. > > Justin Lu has updated the pull request incrementally with two additional > commits since the last revision: > > - Move getErrorCount() back to original spot > - Regardles of nothrow, final result should be logged, cache, move method > back Looks good overall perhaps consider using `HexFormat` instead of the private method `toHexString` ------------- Marked as reviewed by lancea (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/13655#pullrequestreview-1402735283
