On Fri, 28 Apr 2023 17:51:58 GMT, Jan Lahoda <jlah...@openjdk.org> wrote:

>> I believe we were discussing this some time ago, and there were some 
>> problems. I don't recall the exact details, but I'll try to look into this 
>> later.
>
> I've sketched this:
> https://github.com/lahodaj/jdk/commit/efe55f7d354ed7bbf91077d058823d682db501b9
> 
> I don't have too strong opinion here, there might be more cleanup possible 
> after a change like this, and might be a bit cleaner outside of the parser; 
> but forces the parser to work with files which is somewhat less clean.

This is basically what I did originally until I decided that I needed a 
distinct class name. `log.currentSourceFile()` is the magic in this code. I'm 
willing to move this way if we all agree.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13689#discussion_r1180715358

Reply via email to