On Wed, 19 Apr 2023 14:31:36 GMT, Chen Liang <li...@openjdk.org> wrote:
> Spotted the typo for BootstrapMethods, and another review over the API > exposed the typo on PermittedSubclasses. BootstrapMethods is a good catch, however I would rather recommend to remove the `AttributeMapper::validSince` from the API completely. Classfile API has no use of it and it does not perform any checks based on this value. Also the value itself is related to the major version only, so it does not allow to model preview features. PermittedSubclasses attribute is a preview part of JDK 15, see: https://openjdk.org/jeps/360 Real model of attributes and features versioning would have to be more complex and linked with some form of validation. ------------- Changes requested by asotona (Committer). PR Review: https://git.openjdk.org/jdk/pull/13536#pullrequestreview-1408870000
