On Sat, 29 Apr 2023 16:15:58 GMT, Lance Andersen <lan...@openjdk.org> wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Implemented the review comments. > > test/jdk/javax/xml/jaxp/datatype/8033980/SerializationTest.java line 85: > >> 83: >> 84: // Generates the Java Pseudo code for base64 encoded string that >> can be cut & pasted into the test >> 85: final StringBuilder sb = new StringBuilder(); > > Can you please explain the purpose of the following code in the `setup` > method?. This appears to be what you used to generate the > _JDK**X**GregorianCalendarAndDurationSerData.java_ files. I don't see why > this would be needed in a setup method. > > Providing a method, along with comments of how to use it, to create byte > arrays make sense, just not in a setup method. This is added in setup method to create the serialized data with current JDK version (JDK under test). In addition to serialized data generated with old JDK version. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13537#discussion_r1182597550
