On Thu, 27 Apr 2023 16:35:59 GMT, Leonid Mesnik <[email protected]> wrote:
>> The ProcessTools.startProcess (...) has been updated to completely read
>> streams after process has been completed.
>> The test was updated to run 5 times with different number of lines and line
>> sizes.
>
> Leonid Mesnik has updated the pull request incrementally with one additional
> commit since the last revision:
>
> move buffers registration before pumping start point
Okay I _think_ I understand the changes now. I have one small suggestion below
but otherwise this seems okay.
Thanks.
test/lib/jdk/test/lib/process/ProcessTools.java line 190:
> 188: } catch (TimeoutException e) {
> 189: // continue execution, so wait() give a chance
> to write
> 190: } catch (InterruptedException | ExecutionException
> e) {
Probably also need to catch `CancellationException` here for good measure.
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13683#pullrequestreview-1411942808
PR Review Comment: https://git.openjdk.org/jdk/pull/13683#discussion_r1184323176
