On Mon, 8 May 2023 12:17:44 GMT, Jorn Vernee <jver...@openjdk.org> wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Address review comment > > src/java.base/share/classes/jdk/internal/foreign/abi/AbstractLinker.java line > 78: > >> 76: SharedUtils.checkSymbol(symbol); >> 77: return downcallHandle(function, options).bindTo(symbol); >> 78: } > > This doesn't look quite right, as `downcallHandle` is being called twice? > (forgot to push?). > > I suggest calling `Reflection::ensureNativeAccess` immediately in each > overload, and then delegating to `downcallHandle0` which doesn't check the > access. Just a mistake on my part - fixed now ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13863#discussion_r1187503634
