On Tue, 2 May 2023 20:16:15 GMT, Joe Wang <jo...@openjdk.org> wrote:
>> Add a system property, jdk.xml.config.file, to return the path to a custom
>> JAXP configuration file. The current configuration file, jaxp.properties,
>> that the JDK supports will become the default configuration file.
>>
>> CSR: https://bugs.openjdk.org/browse/JDK-8303531
>>
>> Tests: XML SQE and JCK tests passed.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> address review comments
src/java.xml/share/classes/module-info.java line 92:
> 90: * <h3 id="CF_SP">User-defined Configuration File</h3>
> 91: * A system property {@systemProperty java.xml.config.file} can be set on
> the
> 92: * command line or through the System API (e.g. System.setProperty
> method) to
"or through the System API (e.g. System.setProperty)" could be improved to make
it clear that the system property can be set at run-time with
System.setProperty (add link).
src/java.xml/share/conf/jaxp.properties line 2:
> 1:
> ################################################################################
> 2: # XML Library (java.xml) Configuration File
The file is jaxp.properties and the module is Java APIs for XML Processing. The
use of "XML Library (java.xml)" is confusing here, I'm concerned that it will
be inconsistent with all the existing docs.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/12985#discussion_r1185816062
PR Review Comment: https://git.openjdk.org/jdk/pull/12985#discussion_r1185817940
