On Thu, 11 May 2023 09:44:34 GMT, Alan Bateman <[email protected]> wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> http -> https
>
> src/java.base/share/classes/java/text/Collator.java line 131:
>
>> 129: * </blockquote>
>> 130: * may return a {@code Collator} instance with the traditional sorting,
>> which
>> 131: * gives 'v' and 'w' the same sorting order.
>
> The overall intent and wording looks okay but I wonder if it should be in the
> getInstance methods instead. Also wondering whether impNote is right because
> it's both informational for developers using the API and useful to
> implementors.
Thanks. Will move it out of the class description into each `getInstance()`
method, changing @implNote to @apiNote
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13917#discussion_r1191526144
