On Sun, 14 May 2023 05:47:50 GMT, Tagir F. Valeev <[email protected]> wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8308016: Remove ellipses ("...") from snippets
>
> src/java.base/share/classes/java/io/FilePermission.java line 1033:
>
>> 1031: *
>> 1032: * {@snippet lang=java :
>> 1033: * "/tmp/scratch/foo", "read,write",
>
> This doesn't look like a valid Java code. This is not even a well-formed
> expression. I'm not sure whether there are any standard requirements about
> this (the spec is vague here), but IntelliJ IDEA assumes that the Java
> snippet is a member, a statement, or an expression. It's likely that parse
> error will be displayed here in the IDE.
Indeed, maybe a script was used to replace the <pre> </pre> tags, in which case
it will checking for other non-code examples.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13957#discussion_r1193082481