On Fri, 12 May 2023 22:04:24 GMT, Alexander Matveev <[email protected]>
wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Minor source code style cleanup
>
> src/jdk.jpackage/share/classes/jdk/jpackage/internal/CLIHelp.java line 51:
>
>> 49: Log.info(I18N.getString("MSG_Help_no_args"));
>> 50: } else {
>> 51: OperatingSystem platform = OperatingSystem.current();
>
> Should we add if (Log.isVerbose) back? Otherwise default case in switch
> statement never executed.
I was puzzled by that check early on and its still a puzzle. It seems a bit of
a hack overloaded on the platform dispatch.
As it turns out, the only time that `Log.isVerbose()` is true when `showHelp()`
is called is when the environment variable `JPACKAGE_DEBUG` is used for
debugging.
`showHelp()` is only called before argument parsing is done and it doesn't look
for --verbose. See `Main.execute()`
So checking for isVerbose has no practical function.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13586#discussion_r1194314732
