On Wed, 17 May 2023 10:41:57 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
>> Darragh Clarke has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Update
>> src/java.base/share/classes/sun/net/www/protocol/http/DigestAuthentication.java
>>
>> Co-authored-by: Daniel Jelinski <djelins...@gmail.com>
>> - removed StreamTokenizer changes, will make seperate ticket for those
>
> src/java.base/share/classes/sun/net/www/protocol/http/DigestAuthentication.java
> line 516:
>
>> 514:
>> 515: if (nccount != -1) {
>> 516: ncstring = Integer.toHexString
>> (nccount).toLowerCase(Locale.ROOT);
>
> Suggestion:
>
> ncstring = Integer.toHexString(nccount);
>
> `toHexString` returns lowercase string
Thanks for pointing that out!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14006#discussion_r1196555183
