On Wed, 17 May 2023 13:42:32 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Adam Sotona has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 34 commits: >> >> - Merge branch 'master' into JDK-8306842-perf-improvements >> >> # Conflicts: >> # make/RunTests.gmk >> # src/java.base/share/classes/jdk/internal/classfile/impl/Util.java >> - LinkedList replaced with ArrayList in benchmarks >> - Apply suggestions from code review >> >> Co-authored-by: Andrey Turbanov <turban...@gmail.com> >> - changed LinkedList to ArrayList in RebuildMethodBodies benchmark >> - added RepeatedModelTraversal JMH benchmark >> - fixed jmh benchmark parameters >> - fixed StackMapGenerator >> - Apply suggestions from code review >> >> Co-authored-by: liach <7806504+li...@users.noreply.github.com> >> - Merge branch 'master' of https://github.com/openjdk/jdk into >> JDK-8306842-perf-improvements >> >> # Conflicts: >> # >> src/java.base/share/classes/jdk/internal/classfile/impl/DirectCodeBuilder.java >> # >> src/java.base/share/classes/jdk/internal/classfile/impl/StackCounter.java >> # >> src/java.base/share/classes/jdk/internal/classfile/impl/StackMapGenerator.java >> # test/jdk/jdk/classfile/DiscontinuedInstructionsTest.java >> # test/jdk/jdk/classfile/StackMapsTest.java >> - more use of MethodInfo::methodTypeSymbol and faster ClassDesc slot size >> calculation >> - ... and 24 more: https://git.openjdk.org/jdk/compare/5763be72...d99e7ad0 > > test/micro/org/openjdk/bench/jdk/classfile/Write.java line 76: > >> 74: "--add-exports", >> "java.base/jdk.internal.classfile.constantpool=ALL-UNNAMED", >> 75: "--add-exports", >> "java.base/jdk.internal.classfile.instruction=ALL-UNNAMED", >> 76: "--add-exports", >> "java.base/jdk.internal.classfile.java.lang.constant=ALL-UNNAMED", > > Since this package is gone, this export arg can be removed. There are a total > of 3 occurrences I think. Good catch, thanks! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13671#discussion_r1197409528
