Re: RFR: 8308347: [s390x] build broken after JDK-8304913

[Amit Kumar]

On Thu, 18 May 2023 06:40:30 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:

>> s390x needs to be recognised as `S390`. After 
>> [JDK-8304913](https://bugs.openjdk.org/browse/JDK-8304913) during build I 
>> was getting this PluginException: 
>> 
>> jdk.tools.jlink.plugin.PluginException: ModuleTarget is malformed: No enum 
>> constant jdk.internal.util.Architecture.S390X
>>         at 
>> jdk.jlink/jdk.tools.jlink.builder.DefaultImageBuilder.storeFiles(DefaultImageBuilder.java:181)
>>         at 
>> jdk.jlink/jdk.tools.jlink.internal.ImagePluginStack.storeFiles(ImagePluginStack.java:486)
>>         at 
>> jdk.jlink/jdk.tools.jlink.internal.ImageFileCreator.writeImage(ImageFileCreator.java:168)
>>         at 
>> jdk.jlink/jdk.tools.jlink.internal.ImageFileCreator.create(ImageFileCreator.java:100)
>>         at 
>> jdk.jlink/jdk.tools.jlink.internal.JlinkTask$ImageHelper.retrieve(JlinkTask.java:860)
>>         at 
>> jdk.jlink/jdk.tools.jlink.internal.ImagePluginStack.operate(ImagePluginStack.java:194)
>>         at 
>> jdk.jlink/jdk.tools.jlink.internal.JlinkTask.createImage(JlinkTask.java:423)
>>         at 
>> jdk.jlink/jdk.tools.jlink.internal.JlinkTask.run(JlinkTask.java:286)
>>         at jdk.jlink/jdk.tools.jlink.internal.Main.run(Main.java:56)
>>         at jdk.jlink/jdk.tools.jlink.internal.Main.main(Main.java:34)
>> 
>> 
>> Builds tested :`fastdebug, release`.
>
> Looks good and trivial. Thanks for fixing.

Thanks @tstuefe for review. As this is trivial change, Moving ahead with 
integration.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14043#issuecomment-1552549189