On Wed, 17 May 2023 19:40:04 GMT, Naoto Sato <[email protected]> wrote:
> This change intends to interpret the BCP47 U extension wrt collation settings
> in the given `Locale`, then applies them to the created instances in the
> 1-arg factory method in `Collator`. A corresponding CSR has also been drafted.
test/jdk/sun/text/resources/Collator/CollationSettingsTests.java line 43:
> 41:
> 42: public class CollationSettingsTests {
> 43: private static final Collator ENG_DEF =
> Collator.getInstance(Locale.ENGLISH);
nit
Suggestion:
private static final Collator ENG_DEF =
Collator.getInstance(Locale.ENGLISH);
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14040#discussion_r1197616430