On Fri, 19 May 2023 13:01:37 GMT, Adam Sotona <asot...@openjdk.org> wrote:

>> test/jdk/tools/launcher/exeJliLaunchTest.c line 39:
>> 
>>> 37: {
>>> 38:     //avoid null-terminated array of arguments to test JDK-8303669
>>> 39:     char **argv = malloc(sizeof(char *) * argc);
>> 
>> If this is building on all platforms then okay but I would have expected 
>> you'd need a cast here.
>
> I've learned that there are completely opposite rules for C and C++.

Tier1 tests just passed on all platforms.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14060#discussion_r1198935073

Reply via email to