On Fri, 19 May 2023 21:20:19 GMT, Erik Joelsson <er...@openjdk.org> wrote:
> I ran this patch in our internal build and test system and got failures on > macos and windows. Thanks a lot, @erikj79! I was going to ask your help for testing the patch. > I think I know the cause for the mac failure, but the Windows failure I don't > know. It looks like the same error I saw before after the original patch went > in. > > ``` > [2023-05-19T20:51:31,466Z] > c:\sb\prod\1684529071\workspace\open\src\hotspot\share\compiler\disassembler.cpp(792): > error C2220: the following warning is treated as an error > [2023-05-19T20:51:31,466Z] > c:\sb\prod\1684529071\workspace\open\src\hotspot\share\compiler\disassembler.cpp(792): > warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data > [2023-05-19T20:51:31,466Z] lib/CompileJvm.gmk:152: recipe for target > '/cygdrive/c/sb/prod/1684529071/workspace/build/windows-x64-open/hotspot/variant-server/libjvm/objs/static/disassembler.obj' > failed > [2023-05-19T20:51:31,466Z] make[3]: *** > [/cygdrive/c/sb/prod/1684529071/workspace/build/windows-x64-open/hotspot/variant-server/libjvm/objs/static/disassembler.obj] > Error 1 > ``` The warning error looks the same as https://bugs.openjdk.org/browse/JDK-8307858?focusedCommentId=14581027&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14581027. Sorry I didn't look closely earlier. I just took a look of https://github.com/openjdk/jdk/blob/939344b8433b32166f42ad73ae3d96e84b033478/src/hotspot/share/compiler/disassembler.cpp#L792: #ifdef STATIC_BUILD char* p = strrchr(buf, '/'); *p = '\0'; strcat(p, "/lib/"); lib_offset = jvm_offset = strlen(buf); #else The code is only enabled for the static build, which is why the issue doesn't show up in regular JDK build. `strlen` return value is `size_t`. I'll work on a fix. Could you please help fix the mac failure as you have already looked into it. Thanks! ------------- PR Comment: https://git.openjdk.org/jdk/pull/14064#issuecomment-1555290450
