On Wed, 17 May 2023 17:05:54 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> Volker Simonis has updated the pull request incrementally with one >> additional commit since the last revision: >> >> REALLY adding the test :) > > test/jdk/java/lang/ProcessBuilder/JspawnhelperProtocol.java line 78: > >> 76: pb = >> ProcessTools.createJavaProcessBuilder("-Djdk.lang.Process.launchMechanism=posix_spawn", >> 77: >> "JspawnhelperProtocol", >> 78: "normalExec"); > > I would just redirect the output to the parent. > `pb.inheritIO()` and avoid the extra code at line 88. Good suggestion. Done. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13956#discussion_r1200086821