On Fri, 26 May 2023 17:23:01 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:

> Still think it would be cleaner and simpler to set the FD in the parent to 
> CLOEXEC, before doing posix_spawn, and at the same time set the childStuff 
> variable to -1 to prevent the child from attempting to re-close it. 
> Reconsider?

As you say yourself, this code is complex and I therefor hesitate to do any 
refactoring of the code just to make it "cleaner any simpler" (at least not now 
in this PR).

@tstuefe, do you still plan to look at the latest version? Otherwise I want to 
push this in the next day or two.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13956#issuecomment-1568432978

Reply via email to