On Tue, 30 May 2023 12:17:00 GMT, Jorn Vernee <jver...@openjdk.org> wrote:

> The issue is that the fallback linker uses `copyFrom` when copying a by-value 
> struct argument to an internal buffer, without first adjusting the size of 
> the argument segment. This means that if the argument segment is 'too large' 
> (i.e. larger than the layout it was linked with) we fail with an exception 
> since the internal buffer is too small for the entire argument segment to be 
> copied into.
> 
> The fix is simply to use an exactly-sized copy instead, just like we do in 
> other linker implementations. (The argument segment being too large is fine, 
> all we care about is that it's large enough).
> 
> Testing: jdk-tier5

Marked as reviewed by mcimadamore (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/14215#pullrequestreview-1451127172

Reply via email to