On Fri, 2 Jun 2023 22:18:45 GMT, Brian Burkhalter <b...@openjdk.org> wrote:
>> I just wonder if jchar is UTF-16 and char is platform encoding, would it >> work by simply casting the low 8bit to char? > > Probably not. This is only intended to cover the constrained case of this > test. Something like the macro `WITH_PLATFORM_STRING` in `libjava/io_util.h` > would be needed for the general case, but I thought that that might be > overdoing it for here. I could of course be mistaken. OK, if the usage is limited and covers the required test cases, that sounds reasonable. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14276#discussion_r1214899665
