> Class-File API actually throws wide variety of exceptions based on the actual 
> situation. Complete error handling code must cover 
> `IndexOutOfBoundsException`, `IllegalStateException` and 
> `IllegalArgumentException`. 
> 
> Based on previous discussions we decided to consolidate on 
> `IllegalArgumentException` with possible sub-classes. 
> 
> It allows easy common error handling in majority of use case, however it 
> allows also to distinguish source of the error when needed (for example 
> `javap` needs to know if the exception comes from constant poll or not). 
> 
> Newly introduced `ConstantPoolException` extends `IllegalArgumentException` 
> to indicate the source of the problem is in constant pool. 
> 
> Please review.
> 
> Thanks,
> Adam

Adam Sotona has updated the pull request incrementally with one additional 
commit since the last revision:

  added missing ConstantPoolException constructors

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14143/files
  - new: https://git.openjdk.org/jdk/pull/14143/files/65a7e70a..36d29858

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14143&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14143&range=02-03

  Stats: 30 lines in 1 file changed: 27 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/14143.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14143/head:pull/14143

PR: https://git.openjdk.org/jdk/pull/14143

Reply via email to