On Fri, 9 Jun 2023 13:18:07 GMT, Chris Hegarty <[email protected]> wrote:
>> A trivial use of the Vector API when run with the security manager and a
>> domain that does not grant permissions fails with
>> java.security.AccessControlException: access denied
>> ("java.util.PropertyPermission"
>> "jdk.incubator.vector.VECTOR_ACCESS_OOB_CHECK" "read").
>>
>> The fix it minimal, as consistent with other system property access in the
>> JDK - just access the property while asserting privileged. Note: no explicit
>> permission grant to the vector module is required, as it is in the boot
>> loader.
>>
>> This is the only such security manager related issue I see in this code, and
>> I have looked.
>
> Chris Hegarty has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add at bug and remove newline
Marked as reviewed by psandoz (Reviewer).
test/jdk/jdk/incubator/vector/VectorRuns.java line 74:
> 72: return a.length;
> 73:
> 74: int length = a.length & ~(species.length() - 1);
Recommend:
Suggestion:
int length = species.loopBound(a.length);
-------------
PR Review: https://git.openjdk.org/jdk/pull/14392#pullrequestreview-1472841843
PR Review Comment: https://git.openjdk.org/jdk/pull/14392#discussion_r1224610480
