On Fri, 9 Jun 2023 20:03:23 GMT, Erik Joelsson <er...@openjdk.org> wrote:

> All our builds succeeded, so this is looking pretty good now. Just a minor 
> suggestion left.

Thanks a lot!

> This combination of conditions is repeated 3 times. Maybe we could assign the 
> result to a variable (e.g. `$1_ENABLE_PARTIAL_LINKING`) and check for that 
> instead?

Done, thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14064#issuecomment-1585213568
PR Review Comment: https://git.openjdk.org/jdk/pull/14064#discussion_r1224866324

Reply via email to