On Tue, 6 Jun 2023 17:47:02 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> This is rarely used in the code and is not the essence of the current >> changes. >> If you introduce such changes, then throughout the code. >> Moreover, this can lead to problems, such as, for example, here: >> https://bugs.openjdk.org/browse/JDK-8309225 > > I'm not a clang expect, I was just asking if modifying the current `#if > TARGET_OS_MAC` check into `#if defined(__APPLE__)` is also a solution. The > comment on lines 46-47 says the condition was copied from a macOS SDK file > and that's what the file is using now. I think you can create a separate ticket and pull request to discuss this issue. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14033#discussion_r1225842637
